Bot responses reduced
authorMarkus Bröker <mbroeker@largo.dyndns.tv>
Sat, 13 Dec 2008 15:41:52 +0100
changeset 22 b786b5f92a93
parent 21 138537d81dd1
child 23 1cd79bb84e9c
Bot responses reduced committer: Markus Bröker <mbroeker@largo.homelinux.org>
TODO
debian/changelog
src/irc.c
src/parse.c
--- a/TODO
+++ b/TODO
@@ -3,9 +3,10 @@
 #
 
 Known Bugs:
-	* no known bugs :) fixed
 	* PRIVMSG for n=some@unaffiliated/users
 	* strdup must be freed: DONE
+	* the bot must be registered to use op commands
+	  -> works best on irc.freenode.net
 
 Todo:
 	* UTF-8 aware Character-Encoding
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,7 +10,7 @@
   * Debian Policy: Assume everything is working and start the service via default
   * irc_login connects now to the proper (non-freenode.net) server
   * privmsgs will be send to the proper location...
-  * A simple garbage collector fills the memory leaks...
+  * A simple garbage collector prevents memory leaks...
   * compat.c added for XOPEN_SOURCE features - not finished yet
   * SOURCE_URL points to the proper git-location.
   * many small improvements, reduced codebase
@@ -19,6 +19,7 @@
   * op, deop, kick, ban, unban, kickban implemented
   * database.c: key=alloc(dbf, key); free(key.dptr) :) fixed
   * only one memory hole is left: who can fix getpwnam in irc.c
-  * admin commands secured
+  * admin commands secured (works well on irc.freenode.net)
+  * bot responses reduced, error code 486 added
 
- -- Markus Broeker <mbroeker@largo.homelinux.org>  Tue, 12 Aug 2008 14:00:01 +0200
+ -- Markus Broeker <mbroeker@largo.homelinux.org>  Wed, 13 Aug 2008 12:44:01 +0200
--- a/src/irc.c
+++ b/src/irc.c
@@ -345,6 +345,7 @@
             case 475:
             case 476:
             case 477:
+            case 486:          /* MUST BE REGISTERED TO SEND PRIVATE MESSAGES */
             case 482:
             case 901:          /* notify or some crap */
                 message->channel = strtok (message->line, " ");
--- a/src/parse.c
+++ b/src/parse.c
@@ -112,17 +112,14 @@
     if (strstr (message->line, message->nick)) {
         if (*message->line != '!') {
             /*
-             * DEAD - LOCK - CHECK
+             * DEADLOCK-CHECK
              */
             if (strcmp (message->user, message->nick)) {
                 snprintf (msg, 512, "PRIVMSG %s :%s, %s?\r\n", message->channel, gettext ("What's up"), message->user);
-                if (counter++ > 3)
+                if (counter++ > 2)
                     return NULL;
                 return msg;
             }
-            /*
-             * DEAD - LOCK - CHECK ENDS
-             */
         }
         return NULL;
     }